fix(openai): send content: null instead of empty string for tool-call-only assistant messages#12605
Open
giulio-leone wants to merge 2 commits intovercel:mainfrom
Open
Conversation
…stant messages Fixes vercel#12389
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
giulio-leone
force-pushed
the
fix/issue-12389-content-empty-string-null
branch
from
23649d6 to
373edf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12389
Problem
convertToOpenAIChatMessages sends content: "" for assistant messages with only tool calls. Per OpenAI spec, it should be content: null.
Impact
OpenAI-compatible providers (Ollama, etc.) switch from structured tool_calls to text markup when they see content: "" in history.
Fix
Changed content: text to content: text || null - sends null when no text content exists.